Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disconnect client in case acl deny #2059

Merged
merged 3 commits into from Dec 19, 2018

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented Dec 14, 2018

No description provided.

@gilbertwong96 gilbertwong96 requested review from emqplus and terry-xiaoyu Dec 14, 2018
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 14, 2018

Pull Request Test Coverage Report for Build 4113

  • 18 of 25 (72.0%) changed or added relevant lines in 2 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.5%) to 64.479%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_ws_connection.erl 0 3 0.0%
src/emqx_protocol.erl 18 22 81.82%
Files with Coverage Reduction New Missed Lines %
src/emqx_protocol.erl 1 78.14%
src/emqx_access_rule.erl 8 85.19%
src/emqx_acl_internal.erl 10 66.67%
Totals Coverage Status
Change from base Build 4033: 0.5%
Covered Lines: 2948
Relevant Lines: 4572

💛 - Coveralls
@gilbertwong96 gilbertwong96 requested a review from turtleDeng Dec 14, 2018
is_bridge = false,
enable_ban = emqx_zone:get_env(Zone, enable_ban, false),
enable_acl = emqx_zone:get_env(Zone, enable_acl),
acl_deny_action = emqx_zone:get_env(Zone, acl_deny_action, ignore),

This comment has been minimized.

Copy link
@linjunjj

linjunjj Dec 14, 2018

Contributor

Load 'acl_deny_action ' configuration for the first time, Reduce duplicate read configuration, I learned😁😁

@turtleDeng turtleDeng merged commit 7d9e350 into emqx30 Dec 19, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.5%) to 64.479%
Details
@turtleDeng turtleDeng deleted the acl_deny_action branch Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.