Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add will topic validation and acl check #2075

Merged
merged 2 commits into from Dec 21, 2018

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented Dec 19, 2018

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 19, 2018

Pull Request Test Coverage Report for Build 4237

  • 18 of 19 (94.74%) changed or added relevant lines in 2 files are covered.
  • 21 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 64.672%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_protocol.erl 17 18 94.44%
Files with Coverage Reduction New Missed Lines %
src/emqx_mod_presence.erl 1 77.78%
src/emqx_access_rule.erl 6 84.62%
src/emqx_acl_internal.erl 6 68.42%
src/emqx_access_control.erl 8 60.29%
Totals Coverage Status
Change from base Build 4172: 0.2%
Covered Lines: 2962
Relevant Lines: 4580

💛 - Coveralls
@turtleDeng turtleDeng merged commit bf7f10e into emqx30 Dec 21, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 64.672%
Details
@turtleDeng turtleDeng deleted the will-fix branch Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.