Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bridge #2117

Merged
merged 6 commits into from Jan 3, 2019

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented Jan 2, 2019

No description provided.

@gilbertwong96 gilbertwong96 requested a review from turtleDeng Jan 2, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 2, 2019

Pull Request Test Coverage Report for Build 4393

  • 12 of 24 (50.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 63.943%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_bridge.erl 12 24 50.0%
Files with Coverage Reduction New Missed Lines %
src/emqx_router.erl 1 73.68%
src/emqx_client_sock.erl 1 70.37%
src/emqx_client.erl 6 57.44%
Totals Coverage Status
Change from base Build 4367: 0.1%
Covered Lines: 3036
Relevant Lines: 4748

💛 - Coveralls
@gilbertwong96 gilbertwong96 force-pushed the refactor-bridge branch from e32c724 to 98a1ac4 Jan 2, 2019
@turtleDeng turtleDeng merged commit 9a2573d into emqx30 Jan 3, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.06%) to 63.943%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@turtleDeng turtleDeng deleted the refactor-bridge branch Jan 3, 2019
@gilbertwong96 gilbertwong96 restored the refactor-bridge branch Jan 3, 2019
@gilbertwong96 gilbertwong96 deleted the refactor-bridge branch Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.