Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash if peer closed the connection #2120

Merged
merged 1 commit into from Jan 7, 2019

Conversation

@terry-xiaoyu
Copy link
Contributor

terry-xiaoyu commented Jan 3, 2019

Prior to this fix, we would get the following crash if we connected to
another emqx broker but got refused because of wrong username or password.

➜  ./bin/emqx_ctl bridges start aws
RPC to emqx2@127.0.0.1 error: {{{shutdown,tcp_closed},
                                {gen_statem,call,
                                    [<10637.1997.0>,connect,infinity]}},
                               {gen_server,call,
                                   [emqx_bridge_aws,start_bridge]}}
Prior to this fix, we'll get the following crash if we connected to
another emqx broker but got refused because of wrong username or password.

```shell
➜  ./bin/emqx_ctl bridges start aws
RPC to emqx2@127.0.0.1 error: {{{shutdown,tcp_closed},
                                {gen_statem,call,
                                    [<10637.1997.0>,connect,infinity]}},
                               {gen_server,call,
                                   [emqx_bridge_aws,start_bridge]}}
```
@terry-xiaoyu terry-xiaoyu requested review from emqplus and turtleDeng Jan 3, 2019
@turtleDeng turtleDeng merged commit cb93a35 into emqx30 Jan 7, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on fix_crash_peer_reject_conn at 66.316%
Details
@turtleDeng turtleDeng deleted the fix_crash_peer_reject_conn branch Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.