Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the design of 'emqx_client' module #2137

Merged
merged 2 commits into from Jan 10, 2019

Conversation

@emqplus
Copy link
Contributor

emqplus commented Jan 9, 2019

Use '{next_event, cast, Packet}' to replace 'gen_statem:cast/2'

Use '{next_event, cast, Packet}' to replace 'gen_statem:cast/2'
@emqplus emqplus added the Enhancement label Jan 9, 2019
@emqplus emqplus added this to the 3.0.1 milestone Jan 9, 2019
@emqplus emqplus self-assigned this Jan 9, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 9, 2019

Pull Request Test Coverage Report for Build 4465

  • 6 of 9 (66.67%) changed or added relevant lines in 1 file are covered.
  • 265 unchanged lines in 21 files lost coverage.
  • Overall coverage increased (+0.2%) to 66.416%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_client.erl 6 9 66.67%
Files with Coverage Reduction New Missed Lines %
src/emqx_protocol.erl 1 78.57%
src/emqx_pool.erl 1 96.0%
src/emqx_connection.erl 1 64.1%
src/emqx_client.erl 3 58.78%
src/emqx_router.erl 5 91.8%
src/emqx_zone.erl 5 72.41%
src/emqx_banned.erl 6 60.87%
src/emqx_cm.erl 7 81.13%
src/emqx_hooks.erl 7 88.89%
src/emqx_stats.erl 9 78.43%
Totals Coverage Status
Change from base Build 4445: 0.2%
Covered Lines: 3178
Relevant Lines: 4785

💛 - Coveralls
@emqplus emqplus merged commit 5ccaaed into emqx30 Jan 10, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@emqplus emqplus deleted the statem-next-event branch Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.