Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the pool design #2138

Merged
merged 1 commit into from Jan 10, 2019

Conversation

@emqplus
Copy link
Contributor

emqplus commented Jan 9, 2019

  • Move 'emqx_pool:start_link/0' to emqx_pool_sup module
  • Use the new log macros
  • Add more test cases
- Move 'emqx_pool:start_link/0' to emqx_pool_sup module
- Use the new log macros
- Add more test cases
@emqplus emqplus added the Enhancement label Jan 9, 2019
@emqplus emqplus added this to the 3.0.1 milestone Jan 9, 2019
@emqplus emqplus self-assigned this Jan 9, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 9, 2019

Pull Request Test Coverage Report for Build 4449

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 66.416%

Files with Coverage Reduction New Missed Lines %
src/emqx_router.erl 1 91.8%
Totals Coverage Status
Change from base Build 4445: 0.2%
Covered Lines: 3176
Relevant Lines: 4782

💛 - Coveralls
@emqplus emqplus merged commit fe0f533 into emqx30 Jan 10, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 66.416%
Details
@emqplus emqplus deleted the logger branch Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.