Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix will msg #2156

Merged
merged 3 commits into from Jan 17, 2019

Conversation

@tigercl
Copy link
Collaborator

tigercl commented Jan 16, 2019

Solve the problem that EMQ still sends will message when the client sends DISCONNECT packet with reason code 0

@tigercl tigercl requested review from terry-xiaoyu, gilbertwong96 and turtleDeng and removed request for terry-xiaoyu and gilbertwong96 Jan 16, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 16, 2019

Pull Request Test Coverage Report for Build 4519

  • 13 of 15 (86.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 67.105%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_protocol.erl 7 9 77.78%
Totals Coverage Status
Change from base Build 4494: 0.05%
Covered Lines: 3213
Relevant Lines: 4788

💛 - Coveralls
process_packet(?DISCONNECT_PACKET(_), PState) ->
{stop, normal, PState}.
{stop, {shutdown, disconnet_abnormally}, PState}.

This comment has been minimized.

Copy link
@terry-xiaoyu

terry-xiaoyu Jan 16, 2019

Contributor

{shutdown, disconnet_abnormal}

zone => Zone,
client_id => ClientId,
conn_pid => ConnPid,
username => Username,
clean_start => CleanStart,
will_msg => WillMsg
clean_start => CleanStart
},

This comment has been minimized.

Copy link
@terry-xiaoyu

terry-xiaoyu Jan 16, 2019

Contributor

I think constructing this SessAttrs in the caller side is better.

@terry-xiaoyu terry-xiaoyu merged commit bc31faa into emqx30 Jan 17, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 67.105%
Details
@terry-xiaoyu terry-xiaoyu deleted the fix_will_msg branch Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.