Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bridge bug #2160

Merged
merged 3 commits into from Jan 22, 2019

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented Jan 17, 2019

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 17, 2019

Pull Request Test Coverage Report for Build 4537

  • 2 of 15 (13.33%) changed or added relevant lines in 1 file are covered.
  • 55 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+1.2%) to 68.313%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_bridge.erl 2 15 13.33%
Files with Coverage Reduction New Missed Lines %
src/emqx_protocol.erl 1 78.64%
src/emqx_reason_codes.erl 1 99.15%
src/emqx_session.erl 1 70.1%
src/emqx_bridge.erl 3 46.51%
src/emqx_broker.erl 3 64.56%
src/emqx_client.erl 46 58.71%
Totals Coverage Status
Change from base Build 4523: 1.2%
Covered Lines: 3279
Relevant Lines: 4800

💛 - Coveralls
@terry-xiaoyu terry-xiaoyu requested a review from turtleDeng Jan 21, 2019
@turtleDeng turtleDeng merged commit 55ec358 into emqx30 Jan 22, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.2%) to 68.313%
Details
@turtleDeng turtleDeng deleted the fix-bridge-bug branch Jan 22, 2019
turtleDeng added a commit that referenced this pull request Jan 25, 2019
* Change the reason code in will topic acl check (#2168)

* Fix bridge bug (#2160)

* Limit bridge QoS less than 1

* Improve shared sub dispatch implementation. (#2144)

* Upgrade ekka, esockd libraries

* Improve the 'try_open_session' function

* Reload config (#2180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.