Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #2312 #2313

Merged
merged 3 commits into from Mar 16, 2019

Conversation

@spring2maz
Copy link
Contributor

spring2maz commented Mar 15, 2019

fixes #2312

@gilbertwong96

This comment has been minimized.

Copy link
Contributor

gilbertwong96 commented Mar 15, 2019

It seems that pr ci failed. I would dig into the reason.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 15, 2019

Pull Request Test Coverage Report for Build 4990

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 70.139%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_message.erl 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/emqx_router.erl 1 91.8%
src/emqx_mod_presence.erl 1 83.33%
src/emqx_pqueue.erl 1 76.24%
Totals Coverage Status
Change from base Build 4987: -0.03%
Covered Lines: 3488
Relevant Lines: 4973

💛 - Coveralls
@spring2maz spring2maz changed the base branch from master to develop Mar 15, 2019
@terry-xiaoyu terry-xiaoyu merged commit a72a914 into develop Mar 16, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.03%) to 70.139%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@terry-xiaoyu terry-xiaoyu deleted the fix-issue-2312 branch Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.