Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unload emqx_alarm_handler before unloading plugins when shuting down #2316

Merged
merged 1 commit into from Mar 15, 2019

Conversation

@spring2maz
Copy link
Contributor

spring2maz commented Mar 15, 2019

emqx_alarm_handler publishes mqtt messages,
having it running while plugins are shutdown triggered some
annoying crashes

@spring2maz spring2maz changed the base branch from master to develop Mar 15, 2019
emqx_alarm_handler publishes mqtt messages,
having it running while plugins are shutdown triggered some
annoying crashes
@spring2maz spring2maz force-pushed the unload-emqx-alarm-handler-before-plugin-unload branch from 13d5794 to cdc6c6d Mar 15, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 15, 2019

Pull Request Test Coverage Report for Build 5000

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 18 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.3%) to 69.803%

Files with Coverage Reduction New Missed Lines %
src/emqx_alarm_handler.erl 1 82.22%
src/emqx_broker.erl 1 63.92%
src/emqx_metrics.erl 1 77.91%
src/emqx_connection.erl 7 63.03%
src/emqx_session.erl 8 69.39%
Totals Coverage Status
Change from base Build 4996: -0.3%
Covered Lines: 3472
Relevant Lines: 4974

💛 - Coveralls
@turtleDeng turtleDeng merged commit f2df92f into develop Mar 15, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 69.964%
Details
@terry-xiaoyu terry-xiaoyu deleted the unload-emqx-alarm-handler-before-plugin-unload branch Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.