Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alarm report bug #2332

Merged
merged 3 commits into from Mar 21, 2019

Conversation

@tigercl
Copy link
Collaborator

tigercl commented Mar 19, 2019

Broker can set cpu and process alarm repeatedly, but only clear the alarm if it has already been set.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 19, 2019

Pull Request Test Coverage Report for Build 5108

  • 6 of 11 (54.55%) changed or added relevant lines in 2 files are covered.
  • 23 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.03%) to 68.566%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_os_mon.erl 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/emqx_os_mon.erl 1 60.0%
src/emqx_broker.erl 1 64.15%
src/emqx_connection.erl 8 64.29%
src/emqx_session.erl 13 70.0%
Totals Coverage Status
Change from base Build 5077: -0.03%
Covered Lines: 3381
Relevant Lines: 4931

💛 - Coveralls
alarm_handler:clear_alarm(too_many_processes)
end,
{noreply, ensure_check_timer(State)}.
case ProcessAlarm of

This comment has been minimized.

Copy link
@gilbertwong96

gilbertwong96 Mar 20, 2019

Contributor

IsProcessAlarm

@turtleDeng turtleDeng merged commit e732062 into develop Mar 21, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.03%) to 68.566%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@turtleDeng turtleDeng deleted the fix_alarm_bug branch Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.