Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear dup flag if message published first #2337

Merged
merged 2 commits into from Mar 21, 2019

Conversation

@tigercl
Copy link
Collaborator

tigercl commented Mar 20, 2019

No description provided.

@@ -943,7 +943,7 @@ enqueue_msg(Msg, State = #state{mqueue = Q, client_id = ClientId, username = Use

redeliver({PacketId, Msg = #message{qos = QoS}}, State) ->
Msg1 = if

This comment has been minimized.

Copy link
@gilbertwong96

gilbertwong96 Mar 20, 2019

Contributor

set_flag when qos == 1 or qos ==2

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 20, 2019

Pull Request Test Coverage Report for Build 5103

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 68.575%

Files with Coverage Reduction New Missed Lines %
src/emqx_broker.erl 1 64.15%
src/emqx_connection.erl 8 64.29%
Totals Coverage Status
Change from base Build 5077: -0.02%
Covered Lines: 3378
Relevant Lines: 4926

💛 - Coveralls
@gilbertwong96 gilbertwong96 merged commit 5a401c4 into develop Mar 21, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 68.46%
Details
@gilbertwong96 gilbertwong96 deleted the dup_flag branch Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.