Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allow_anonymous behavoir error #2355

Merged
merged 2 commits into from Mar 26, 2019

Conversation

@HJianBo
Copy link
Member

HJianBo commented Mar 25, 2019

EMQ should allow the anonymous connection if the allow_anonymous option is true, although it has one or more auth plugins started.

@HJianBo HJianBo changed the base branch from master to develop Mar 25, 2019
end;

detect_anonymous_permission(_Credentials, Fun) ->
Fun.

This comment has been minimized.

Copy link
@gilbertwong96

gilbertwong96 Mar 25, 2019

Contributor

Fun().

@HJianBo HJianBo force-pushed the fix_allow_anonymous branch from 40304e2 to 856a228 Mar 25, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 26, 2019

Pull Request Test Coverage Report for Build 5184

  • 9 of 12 (75.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 68.753%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_access_control.erl 9 12 75.0%
Files with Coverage Reduction New Missed Lines %
src/emqx_broker.erl 1 64.15%
Totals Coverage Status
Change from base Build 5158: 0.04%
Covered Lines: 3384
Relevant Lines: 4922

💛 - Coveralls
@gilbertwong96 gilbertwong96 merged commit 8d92d58 into develop Mar 26, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 68.753%
Details
@gilbertwong96 gilbertwong96 deleted the fix_allow_anonymous branch Mar 26, 2019
HJianBo added a commit that referenced this pull request May 15, 2019
HJianBo added a commit that referenced this pull request May 15, 2019
    - Add anonymous field for credentials
@HJianBo HJianBo referenced this pull request May 15, 2019
terry-xiaoyu added a commit that referenced this pull request May 15, 2019
    - Add anonymous field for credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.