Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to pass ws compressing options #2356

Merged
merged 5 commits into from Mar 27, 2019

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented Mar 25, 2019

Prior to this change, emqx_ws_connection does not support compress websocket message. This change implement this feature.

@gilbertwong96 gilbertwong96 changed the base branch from master to develop Mar 25, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 25, 2019

Pull Request Test Coverage Report for Build 5192

  • 7 of 9 (77.78%) changed or added relevant lines in 1 file are covered.
  • 32 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.2%) to 68.49%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_ws_connection.erl 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
src/emqx_router.erl 1 91.8%
src/emqx_session.erl 3 69.09%
src/emqx_access_control.erl 5 76.0%
src/emqx_client.erl 7 49.62%
src/emqx_message.erl 16 63.64%
Totals Coverage Status
Change from base Build 5158: -0.2%
Covered Lines: 3380
Relevant Lines: 4935

💛 - Coveralls
@tigercl tigercl merged commit 2534b8d into develop Mar 27, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.2%) to 68.49%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tigercl tigercl deleted the enhance-ws branch Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.