Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add etcd client certificate configuration #2367

Merged
merged 6 commits into from Mar 27, 2019

Conversation

@linjunjj
Copy link
Contributor

linjunjj commented Mar 27, 2019

Add etcd client certificate configuration

linjunjj added 2 commits Mar 26, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 27, 2019

Pull Request Test Coverage Report for Build 5225

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 104 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.2%) to 68.453%

Files with Coverage Reduction New Missed Lines %
src/emqx_broker.erl 1 64.15%
src/emqx_pqueue.erl 1 76.24%
src/emqx_os_mon.erl 3 58.54%
src/emqx_vm_mon.erl 3 82.76%
src/emqx_session.erl 3 69.09%
src/emqx_message.erl 4 59.57%
src/emqx_client.erl 7 49.62%
src/emqx_ws_connection.erl 27 63.56%
src/emqx_protocol.erl 55 78.98%
Totals Coverage Status
Change from base Build 5186: -0.2%
Covered Lines: 3385
Relevant Lines: 4945

💛 - Coveralls
## Value: File
# cluster.etcd.ssl.cacertfile = {{ platform_etc_dir }}/cacert/ca.pem

##Path to a file containing the client's private PEM-encoded key.

This comment has been minimized.

Copy link
@HJianBo

HJianBo Mar 27, 2019

Member

## Path

linjunjj added 2 commits Mar 27, 2019
## Path to a file containing the client's private PEM-encoded key.
##
## Value: File
## cluster.etcd.ssl.keyfile = {{ platform_etc_dir }}/certs/client-key.pem

This comment has been minimized.

Copy link
@tigercl

tigercl Mar 27, 2019

Collaborator

Move keyfile to top

linjunjj added 2 commits Mar 27, 2019
@turtleDeng turtleDeng merged commit fee9452 into develop Mar 27, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.2%) to 68.613%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@turtleDeng turtleDeng deleted the etcd_tls_config branch Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.