Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Detect Flapping #2438

Merged
merged 4 commits into from Apr 19, 2019

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented Apr 15, 2019

No description provided.

@gilbertwong96 gilbertwong96 changed the title Note: this pr is still on work NOTE: This is still a work-in-progress PR. Apr 15, 2019
@gilbertwong96 gilbertwong96 force-pushed the flapping branch from b22b017 to 0908512 Apr 17, 2019
case time2min(TimeDiff) of
1 when CheckTimes > Threshold ->
flapping;
Minutes when Minutes =< Expiry ->

This comment has been minimized.

Copy link
@tigercl

tigercl Apr 18, 2019

Collaborator

Expiry -> ExpiryInterval

@gilbertwong96 gilbertwong96 force-pushed the flapping branch 2 times, most recently from 960e365 to 2c2eadc Apr 18, 2019
@gilbertwong96 gilbertwong96 marked this pull request as ready for review Apr 18, 2019
@gilbertwong96 gilbertwong96 changed the title NOTE: This is still a work-in-progress PR. Implemet Detect Flapping Apr 18, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 18, 2019

Pull Request Test Coverage Report for Build 5467

  • 43 of 59 (72.88%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 68.79%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_connection.erl 2 3 66.67%
src/emqx_protocol.erl 12 13 92.31%
src/emqx_flapping.erl 20 34 58.82%
Files with Coverage Reduction New Missed Lines %
src/emqx_protocol.erl 1 80.39%
src/emqx_flapping.erl 1 57.14%
Totals Coverage Status
Change from base Build 5427: 0.3%
Covered Lines: 3467
Relevant Lines: 5040

💛 - Coveralls
@gilbertwong96 gilbertwong96 changed the title Implemet Detect Flapping Implement Detect Flapping Apr 18, 2019
@gilbertwong96 gilbertwong96 force-pushed the flapping branch 2 times, most recently from e6e1e49 to d016bf0 Apr 19, 2019
@gilbertwong96 gilbertwong96 force-pushed the flapping branch from ff3cc23 to c8fcf11 Apr 19, 2019
@turtleDeng turtleDeng merged commit cb52205 into develop Apr 19, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 68.651%
Details
@turtleDeng turtleDeng deleted the flapping branch Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.