Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor flapping code #2476

Merged
merged 4 commits into from Apr 24, 2019

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented Apr 23, 2019

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 23, 2019

Pull Request Test Coverage Report for Build 5503

  • 4 of 8 (50.0%) changed or added relevant lines in 2 files are covered.
  • 12 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.1%) to 68.898%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_flapping.erl 2 6 33.33%
Files with Coverage Reduction New Missed Lines %
src/emqx_alarm_handler.erl 1 80.0%
src/emqx_protocol.erl 1 80.07%
src/emqx_connection.erl 1 67.86%
src/emqx_pqueue.erl 1 76.24%
src/emqx_misc.erl 1 89.74%
src/emqx_client.erl 7 49.62%
Totals Coverage Status
Change from base Build 5481: 0.1%
Covered Lines: 3469
Relevant Lines: 5035

💛 - Coveralls
@turtleDeng turtleDeng requested a review from terry-xiaoyu Apr 23, 2019
@turtleDeng turtleDeng merged commit eaa1dea into develop Apr 24, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 68.818%
Details
@turtleDeng turtleDeng deleted the optimize-flapping branch Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.