Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad config type of long_gc #2504

Merged
merged 3 commits into from May 8, 2019

Conversation

@tigercl
Copy link
Collaborator

tigercl commented May 5, 2019

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 5, 2019

Pull Request Test Coverage Report for Build 5592

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 45 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 68.767%

Files with Coverage Reduction New Missed Lines %
src/emqx_client.erl 7 49.62%
src/emqx_stats.erl 13 75.47%
src/emqx_ws_connection.erl 25 62.1%
Totals Coverage Status
Change from base Build 5515: -0.1%
Covered Lines: 3459
Relevant Lines: 5030

💛 - Coveralls
@HJianBo
HJianBo approved these changes May 5, 2019
@@ -66,7 +66,7 @@ parse_opt(Opts) ->
parse_opt(Opts, []).
parse_opt([], Acc) ->
Acc;
parse_opt([{long_gc, false}|Opts], Acc) ->
parse_opt([{long_gc, 0}|Opts], Acc) ->

This comment has been minimized.

Copy link
@gilbertwong96

gilbertwong96 May 6, 2019

Contributor

When long_gc value is 0, it equals disable long_gc, you can refer here

@@ -66,7 +66,7 @@ parse_opt(Opts) ->
parse_opt(Opts, []).
parse_opt([], Acc) ->
Acc;
parse_opt([{long_gc, false}|Opts], Acc) ->
parse_opt([{long_gc, 0}|Opts], Acc) ->
parse_opt(Opts, Acc);
parse_opt([{long_gc, Ms}|Opts], Acc) when is_integer(Ms) ->
parse_opt(Opts, [{long_gc, Ms}|Acc]);

This comment has been minimized.

Copy link
@gilbertwong96

gilbertwong96 May 6, 2019

Contributor

long_schedule is same as above. refer here

Regulate the options of erlang system_monitor in emqx
@tigercl tigercl merged commit 7e0ac5b into develop May 8, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@tigercl tigercl deleted the fix_long_gc branch May 8, 2019
HJianBo added a commit that referenced this pull request May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.