Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force shutdown #2515

Merged
merged 4 commits into from May 7, 2019

Conversation

@terry-xiaoyu
Copy link
Contributor

terry-xiaoyu commented May 7, 2019

The erlang:process_flag(max_heap_size, MaxHeapSize) can only set a MaxHeapSize of small integer, which is smaller than 2^59 on 64-bit systems, and 2^27 on 32-bit systems.

terry-xiaoyu added 3 commits May 5, 2019
Set default max-queue-len to 10000, and default max-heap-size to 1024MB.
The erlang:process_flag(max_heap_size, MaxHeapSize) can only set a MaxHeapSize of `small integer`, which is smaller than 2^59 on 64-bit systems, and 2^27 on 32-bit systems.
@terry-xiaoyu terry-xiaoyu requested review from gilbertwong96 and tigercl May 7, 2019
Copy link
Contributor

gilbertwong96 left a comment

Good! But I suppose the variable name is controversy.

@@ -899,15 +899,34 @@ end}.
count => list_to_integer(Count)}
end,
{force_gc_policy, GcPolicy};
("force_shutdown_policy", "default") ->
{DefaultLen, DefaultSiz} =

This comment has been minimized.

Copy link
@gilbertwong96

gilbertwong96 May 7, 2019

Contributor

I suppose that it is better to call DefaultSiz as DefaultSize or DefaultSz

max_heap_size => Siz1}
end,
MaxSiz = case erlang:system_info(wordsize) of
8 -> % arch_64

This comment has been minimized.

Copy link
@gilbertwong96

gilbertwong96 May 7, 2019

Contributor

Here:

case erlang:system_info(wordsize) of
 8 -> % arch_64

maybe it is better to indent 4 space ?

@terry-xiaoyu terry-xiaoyu merged commit 7b356e8 into develop May 7, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.02%) to 68.668%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@gilbertwong96 gilbertwong96 deleted the force_shutdown branch May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.