Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better zone #2548

Merged
merged 5 commits into from May 25, 2019

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented May 17, 2019

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 17, 2019

Pull Request Test Coverage Report for Build 5666

  • 67 of 74 (90.54%) changed or added relevant lines in 4 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.09%) to 68.835%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_connection.erl 4 5 80.0%
src/emqx_protocol.erl 49 52 94.23%
src/emqx_session.erl 10 13 76.92%
Files with Coverage Reduction New Missed Lines %
src/emqx_packet.erl 1 84.21%
src/emqx_session.erl 1 70.06%
src/emqx_protocol.erl 4 81.29%
Totals Coverage Status
Change from base Build 5651: 0.09%
Covered Lines: 3481
Relevant Lines: 5057

💛 - Coveralls
src/emqx_protocol.erl Show resolved Hide resolved
src/emqx_protocol.erl Show resolved Hide resolved
This change aims to improve the performance which anonymous function brought.
@gilbertwong96 gilbertwong96 force-pushed the better-zone branch from 7eca37d to 6b5658a May 19, 2019
@turtleDeng turtleDeng merged commit 0857b97 into develop May 25, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.09%) to 68.835%
Details
@turtleDeng turtleDeng deleted the better-zone branch May 25, 2019
@phanimahesh

This comment has been minimized.

Copy link
Contributor

phanimahesh commented Jun 5, 2019

This silently fixed a bug I've been banging my head against. Prior to this, anonymous users in internal zone with enable_acl false would still get acls applied, because check_pub_acl was matching for both is_superuser in credentials, and the key does not exist at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.