Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the emqx_connection, emqx_ws_connection and emqx_frame modules #2611

Merged
merged 3 commits into from Jun 14, 2019

Conversation

@emqplus
Copy link
Contributor

emqplus commented Jun 12, 2019

  • Rename the emqx_connection module to emqx_channel
  • Rename the emqx_wx_connecton module to emqx_ws_channel
  • Improve the emqx_frame:parse/2 function to return the new parse state
@emqplus emqplus added this to the 3.2-beta.1 milestone Jun 12, 2019
@emqplus emqplus self-assigned this Jun 12, 2019
@turtleDeng turtleDeng modified the milestones: 3.2-beta.1, 3.2-beta.3 Jun 12, 2019
@turtleDeng turtleDeng changed the base branch from master to develop Jun 12, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 12, 2019

Pull Request Test Coverage Report for Build 5815

  • 47 of 78 (60.26%) changed or added relevant lines in 6 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 69.027%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_client.erl 4 5 80.0%
src/emqx_protocol.erl 0 2 0.0%
src/emqx_frame.erl 14 17 82.35%
src/emqx_channel.erl 18 29 62.07%
src/emqx_ws_channel.erl 10 24 41.67%
Files with Coverage Reduction New Missed Lines %
src/emqx_frame.erl 1 93.36%
src/emqx_pqueue.erl 1 76.24%
src/emqx_client.erl 7 49.75%
Totals Coverage Status
Change from base Build 5809: -0.1%
Covered Lines: 3548
Relevant Lines: 5140

💛 - Coveralls
emqplus added 2 commits Jun 11, 2019
- Improve emqx_client to Use the new emqx_frame:parse/2
- Update the ct suites for emqx_channel, emqx_ws_channel
@gilbertwong96 gilbertwong96 merged commit 1d88f8f into develop Jun 14, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.1%) to 69.027%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@gilbertwong96 gilbertwong96 deleted the channel branch Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.