Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ws bug #2615

Merged
merged 3 commits into from Jun 14, 2019

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented Jun 12, 2019

No description provided.

Prior to this change, websocket connection would be closed directly
without sending connack packet when acl check fails.

This change fix this bug.
This change
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 12, 2019

Pull Request Test Coverage Report for Build 5808

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 19 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.2%) to 68.912%

Files with Coverage Reduction New Missed Lines %
src/emqx_packet.erl 1 84.21%
src/emqx_session_sup.erl 1 48.72%
src/emqx_pqueue.erl 1 76.24%
src/emqx_connection.erl 6 66.47%
src/emqx_session.erl 10 69.3%
Totals Coverage Status
Change from base Build 5800: -0.2%
Covered Lines: 3540
Relevant Lines: 5137

💛 - Coveralls
@terry-xiaoyu terry-xiaoyu merged commit d3e7d1f into develop Jun 14, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@terry-xiaoyu terry-xiaoyu deleted the fix-ws-bug branch Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.