Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue#2619 #2646

Merged
merged 2 commits into from Jun 21, 2019

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented Jun 21, 2019

Prior to this change, the websocket connection would not be disconnected
when the dataframe type is the other frame type. However, in the mqtt spec, it
should be disconnected.

Here is the mqtt 5.0 spec

This change fixes this inconsistent behavior with the mqtt 5.0 spec

Prior to this change, websocket connection would not be disconnected
when dataframe type is other frametype. However, in mqtt spec, it
shoud be disconnected.

This change fix this inconsistent behaviour with mqtt 5.0
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 21, 2019

Pull Request Test Coverage Report for Build 5868

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 70.739%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_ws_channel.erl 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
src/emqx_router.erl 1 91.8%
src/emqx_alarm_handler.erl 1 75.56%
Totals Coverage Status
Change from base Build 5859: 0.05%
Covered Lines: 3648
Relevant Lines: 5157

💛 - Coveralls
@turtleDeng turtleDeng merged commit 475cabd into develop Jun 21, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 70.739%
Details
@turtleDeng turtleDeng deleted the mqtt5.0-feature branch Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.