Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid emqx crashes due to auth plugins #3048

Merged
merged 2 commits into from Nov 23, 2019

Conversation

@tigercl
Copy link
Collaborator

tigercl commented Nov 21, 2019

No description provided.

tigercl added 2 commits Nov 21, 2019
@tigercl tigercl merged commit d730b24 into release-3.2 Nov 23, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@tigercl tigercl deleted the safe_execute32 branch Nov 23, 2019
@jinrm

This comment has been minimized.

Copy link

jinrm commented Nov 29, 2019

@tigercl
I verified this for the mqx_auth_mysql plugin and found the problem was resolved. But it still exists in the emqx_auth_pgsql plugin.

The steps to reproduce:

  1. Start pgsql db and config emqx_auth_pgsql.conf with the correct setting
  2. Start EMQ X 3.2.6, and load the plugin of emqx_auth_pgsql sucessfully
  3. Edit emqx_auth_pgsql.conf and make some wrong setting on purpose, for example, delete the value of auth.pgsql.database
  4. Stop the broker
  5. Try to start the broker, you'll find it cannot be started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.