Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the process of handling MQTT control packets #3079

Merged
merged 18 commits into from Dec 6, 2019
Merged

Conversation

@emqplus
Copy link
Contributor

emqplus commented Dec 5, 2019

  • Add 'handle_deliver/2' function in emqx_channel module
  • Ack or nack the delivers from shared subscription
  • Change the default value of 'max_topic_alias'
  • Remove the 'deliver_stats' field from 'session' record
emqplus added 14 commits Nov 25, 2019
- Add 'handle_deliver/2' function in 'emqx_channel' module
- Ack or nack the delivers from shared subscription
- Change the default value of 'max_topic_alias'
- Remove the 'deliver_stats' field from 'session' record
@emqplus emqplus added the Enhancement label Dec 5, 2019
@emqplus emqplus added this to the 4.0-rc.1 milestone Dec 5, 2019
@emqplus emqplus self-assigned this Dec 5, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 5, 2019

Pull Request Test Coverage Report for Build 6988

  • 221 of 306 (72.22%) changed or added relevant lines in 11 files are covered.
  • 22 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.3%) to 86.916%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_connection.erl 27 31 87.1%
src/emqx_cm.erl 17 23 73.91%
src/emqx_ws_connection.erl 8 20 40.0%
src/emqx_session.erl 27 45 60.0%
src/emqx_channel.erl 112 157 71.34%
Files with Coverage Reduction New Missed Lines %
src/emqx_banned.erl 1 90.0%
src/emqx_packet.erl 1 95.92%
src/emqx_ws_connection.erl 3 48.44%
src/emqx_connection.erl 4 82.04%
src/emqx_shared_sub.erl 5 87.4%
src/emqx_channel.erl 8 76.54%
Totals Coverage Status
Change from base Build 6968: -0.3%
Covered Lines: 3979
Relevant Lines: 4578

💛 - Coveralls
emqplus added 3 commits Dec 6, 2019
- Remove the 'emqx_channel_attrs', 'emqx_channel_stats' tables
- Add the 'emqx_channel_info' and 'emqx_channel_conn' tables
- Rename the funcs 'set_chan_attrs' to 'set_chan_info'
- Rename the funcs 'get_chan_attrs' to 'get_chan_info'
- Rename 'awaiting_rel_timeout' field to 'await_rel_timeout' in session
- Remove the 'attrs/1' function from channel and session modules
- Improve the process of handling sock_error, sock_closed events
@turtleDeng turtleDeng merged commit 9c3273a into develop Dec 6, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.3%) to 86.916%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@emqplus emqplus deleted the control-packets branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.