Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'emqx_ws_connection' module and add more test cases #3106

Merged
merged 1 commit into from Dec 13, 2019

Conversation

@emqplus
Copy link
Contributor

emqplus commented Dec 13, 2019

No description provided.

@emqplus emqplus added the Tests label Dec 13, 2019
@emqplus emqplus added this to the 4.0-rc.2 milestone Dec 13, 2019
@emqplus emqplus requested review from tigercl and zhanghongtong Dec 13, 2019
@emqplus emqplus self-assigned this Dec 13, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 13, 2019

Pull Request Test Coverage Report for Build 7053

  • 96 of 114 (84.21%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.9%) to 89.549%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_connection.erl 4 7 57.14%
src/emqx_ws_connection.erl 86 101 85.15%
Files with Coverage Reduction New Missed Lines %
src/emqx_banned.erl 1 90.0%
src/emqx_ws_connection.erl 1 86.81%
Totals Coverage Status
Change from base Build 7046: 1.9%
Covered Lines: 4130
Relevant Lines: 4612

💛 - Coveralls
@emqplus emqplus merged commit c5c99b7 into develop Dec 13, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.9%) to 89.549%
Details
@emqplus emqplus deleted the improve-ws-conn branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.