Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more metrics and improve the 'channel', 'session' modules #3128

Merged
merged 5 commits into from Dec 20, 2019
Merged

Conversation

@emqplus
Copy link
Contributor

emqplus commented Dec 20, 2019

New metrics:

Message metrics

  • messages.dropped.expired
  • messages.dropped.no_subscribers
  • messages.forward
  • messages.delayed

Delivery metrics:

  • delivery.dropped
  • delivery.dropped.no_local
  • delivery.dropped.too_large
  • delivery.dropped.qos0_msg
  • delivery.dropped.queue_full
  • delivery.dropped.expired

Client Lifecircle metrics

  • client.connected
  • client.authenticate
  • client.auth.anonymous
  • client.check_acl
  • client.subscribe
  • client.unsubscribe
  • client.disconnected

Session Lifecircle metrics

  • session.created
  • session.resumed
  • session.takeovered
  • session.discarded
  • session.terminated

Deprecated metrics:

  • channel.gc
  • messages.qos2.expired
  • messages.qos2.dropped
  • auth.mqtt.anonymous
@emqplus emqplus added this to the 4.0-rc.3 milestone Dec 20, 2019
@emqplus emqplus self-assigned this Dec 20, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 20, 2019

Pull Request Test Coverage Report for Build 7112

  • 140 of 164 (85.37%) changed or added relevant lines in 8 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 91.717%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_channel.erl 20 21 95.24%
src/emqx_connection.erl 1 2 50.0%
src/emqx_ws_connection.erl 1 2 50.0%
src/emqx_metrics.erl 84 86 97.67%
src/emqx_session.erl 14 20 70.0%
src/emqx_broker.erl 12 25 48.0%
Files with Coverage Reduction New Missed Lines %
src/emqx_banned.erl 1 90.0%
src/emqx_session.erl 1 89.07%
src/emqx_ws_connection.erl 1 84.75%
src/emqx_connection.erl 2 93.95%
Totals Coverage Status
Change from base Build 7108: -0.1%
Covered Lines: 4274
Relevant Lines: 4660

💛 - Coveralls
@HJianBo HJianBo merged commit 5783554 into develop Dec 20, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.1%) to 91.717%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@HJianBo HJianBo deleted the new-metrics branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.