Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emqx_mgmt): call emqx_alarm:delete_all_deactivated_alarms for rem… #9280

Merged
merged 2 commits into from Nov 4, 2022

Conversation

sstrigler
Copy link
Contributor

@sstrigler sstrigler commented Nov 1, 2022

…ote nodes

Old call was calling a non-existant function on current module, instead we make call directly into emqx_alarm on remote node.

Fixes

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For EMQX 4.x: appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change, and another jira tickt to track doc updates (if any)
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

Backward Compatibility

More information

@sstrigler
Copy link
Contributor Author

No idea how to test this, would need help if test is strictly required.

changes/v4.3.22-zh.md Outdated Show resolved Hide resolved
…ote nodes

Old call was calling a non-existant function on current module, instead we make
call directly into `emqx_alarm` on remote node.
@sstrigler sstrigler force-pushed the EMQX-7665-cannot-clear-alarms branch from 89b9076 to 835d3a3 Compare November 3, 2022 13:03
@zmstone zmstone changed the base branch from main-v4.3 to release-v43 November 4, 2022 15:11
@zmstone zmstone merged commit e73657a into emqx:release-v43 Nov 4, 2022
@sstrigler sstrigler deleted the EMQX-7665-cannot-clear-alarms branch February 17, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants