Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the design of esockd_connection_sup module #86

Merged
merged 4 commits into from Sep 21, 2018

Conversation

@emqplus
Copy link
Contributor

emqplus commented Sep 13, 2018

  1. Use map to store connection pids instead of process dictionary.
  2. Change the format of record definition in some modules.
  3. Bump version to 5.4.1
1. Use map to store connection pids instead of process dictionary.
2. Change the format of record definition in some modules.
@emqplus emqplus added the enhancement label Sep 13, 2018
@emqplus emqplus added this to the 5.4.1 milestone Sep 13, 2018
@emqplus emqplus self-assigned this Sep 13, 2018
@zmstone

This comment has been minimized.

Copy link

zmstone commented Sep 13, 2018

travis is failing because gen_statem is not present in otp 17 18
remove them (and perhaps add 21) to get a green build.

end;
false -> {reply, {error, forbidden}, State}
true ->
case catch start_connection_proc(MFA, Sock) of

This comment has been minimized.

Copy link
@spring2maz

spring2maz Sep 13, 2018

direct catch of an expression is considered deprecated.
always use try catch like below instead:

try
  expr
catch _ : _ ->
end.
emqplus added 2 commits Sep 14, 2018
Specify the opt_release to 21.0.4
1. Update the travis image
2. Update author
Feng Lee
@emqplus emqplus merged commit 4a3886f into emqx30 Sep 21, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@emqplus emqplus deleted the issue#84 branch Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.