From a977211a9cb7a13459559b5f6e21cabd92850012 Mon Sep 17 00:00:00 2001 From: Jiajie Hu Date: Thu, 25 Oct 2018 14:14:48 +0800 Subject: [PATCH] retire USES_GL_EMULATION --- src/compiler.js | 4 ---- src/library_browser.js | 2 +- src/library_gl.js | 10 +++++----- src/library_vr.js | 2 +- 4 files changed, 7 insertions(+), 11 deletions(-) diff --git a/src/compiler.js b/src/compiler.js index 3b0e8ecf3a69..424e9b320588 100644 --- a/src/compiler.js +++ b/src/compiler.js @@ -169,10 +169,6 @@ EXPORTED_FUNCTIONS = set(EXPORTED_FUNCTIONS); EXCEPTION_CATCHING_WHITELIST = set(EXCEPTION_CATCHING_WHITELIST); IMPLEMENTED_FUNCTIONS = set(IMPLEMENTED_FUNCTIONS); -// TODO: Implement support for proper preprocessing, e.g. "#if A || B" and "#if defined(A) || defined(B)" to -// avoid needing this here. -USES_GL_EMULATION = FULL_ES2 || LEGACY_GL_EMULATION; - DEAD_FUNCTIONS.forEach(function(dead) { DEFAULT_LIBRARY_FUNCS_TO_INCLUDE.push(dead.substr(1)); }); diff --git a/src/library_browser.js b/src/library_browser.js index 356539f06972..bbfe58e98c4a 100644 --- a/src/library_browser.js +++ b/src/library_browser.js @@ -1188,7 +1188,7 @@ var LibraryBrowser = { // Signal GL rendering layer that processing of a new frame is about to start. This helps it optimize // VBO double-buffering and reduce GPU stalls. -#if USES_GL_EMULATION +#if FULL_ES2 || LEGACY_GL_EMULATION GL.newRenderingFrameStarted(); #endif diff --git a/src/library_gl.js b/src/library_gl.js index 4e42f472908c..83d3b006efe0 100644 --- a/src/library_gl.js +++ b/src/library_gl.js @@ -40,7 +40,7 @@ var LibraryGL = { syncs: [], #endif -#if USES_GL_EMULATION +#if FULL_ES2 || LEGACY_GL_EMULATION currArrayBuffer: 0, currElementArrayBuffer: 0, #endif @@ -77,7 +77,7 @@ var LibraryGL = { unpackAlignment: 4, // default alignment is 4 bytes init: function() { -#if USES_GL_EMULATION +#if FULL_ES2 || LEGACY_GL_EMULATION GL.createLog2ceilLookup(GL.MAX_TEMP_BUFFER_SIZE); #endif GL.miniTempBuffer = new Float32Array(GL.MINI_TEMP_BUFFER_SIZE); @@ -113,7 +113,7 @@ var LibraryGL = { miniTempBuffer: null, miniTempBufferViews: [0], // index i has the view of size i+1 -#if USES_GL_EMULATION +#if FULL_ES2 || LEGACY_GL_EMULATION // When user GL code wants to render from client-side memory, we need to upload the vertex data to a temp VBO // for rendering. Maintain a set of temp VBOs that are created-on-demand to appropriate sizes, and never destroyed. // Also, for best performance the VBOs are double-buffered, i.e. every second frame we switch the set of VBOs we @@ -3642,7 +3642,7 @@ var LibraryGL = { #endif var bufferObj = buffer ? GL.buffers[buffer] : null; -#if USES_GL_EMULATION +#if FULL_ES2 || LEGACY_GL_EMULATION if (target == GLctx.ARRAY_BUFFER) { GL.currArrayBuffer = buffer; #if LEGACY_GL_EMULATION @@ -4282,7 +4282,7 @@ var LibraryGL = { #endif GLctx['bindVertexArray'](GL.vaos[vao]); #endif -#if USES_GL_EMULATION +#if FULL_ES2 || LEGACY_GL_EMULATION var ibo = GLctx.getParameter(GLctx.ELEMENT_ARRAY_BUFFER_BINDING); GL.currElementArrayBuffer = ibo ? (ibo.name | 0) : 0; #endif diff --git a/src/library_vr.js b/src/library_vr.js index b1811ae651ca..1dd29cadbc2f 100644 --- a/src/library_vr.js +++ b/src/library_vr.js @@ -195,7 +195,7 @@ var LibraryWebVR = { /* Prevent scheduler being called twice when loop is changed */ display.mainLoop.running = true; -#if USES_GL_EMULATION +#if FULL_ES2 || LEGACY_GL_EMULATION GL.newRenderingFrameStarted(); #endif