New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if SIDE_MODULE=1 without either EXPORT_ALL or EXPORTED_FUNCTIONS #7974

Open
Beuc opened this Issue Feb 1, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@Beuc
Copy link
Contributor

Beuc commented Feb 1, 2019

AFAIU, in dynamic linking a side module would be useless without either EXPORT_ALL=1 or EXPORT_FUNCTIONS set.
Hence emcc could warn the user when neither option are present.
(I just spent forever updating a dynamic linking experiment I had done last year...)

@pmp-p

This comment has been minimized.

Copy link

pmp-p commented Feb 2, 2019

maybe could prevent #7811

@kripken

This comment has been minimized.

Copy link
Member

kripken commented Feb 4, 2019

Good idea @Beuc!

The place to add this is in emcc.py, can search for SIDE_MODULE there to find the right code area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment