Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
asyncify WHITELIST wildcard matching #9381
In my project some function names are not predictable, so I need some wildcard system in ASYNCIFY_WHITELIST.
With Emterpreter that could be due to naming conflicts in the various object files; with asyncify/upstream I cannot tell for sure, llvm-nm shows me 28
It can also be due to cython-generated functions which AFAICS may change depending on line number or function ordering. Here I want to match
I also hit this when converting an emterpreter project to asyncify...the wildcards came up as errors.
On another incompatibility note: the names for the EMTERPRETIFY_WHITELIST had leading underscores...and the ASYNCIFY_WHITELIST seemed to not want those underscores. That may be worth explaining/mentioning in "Migrating from Older APIs" on the Asyncify page
I often forget that the "technical" term for wildcard matching with asterisks in a file-path type way is "globbing":
Seems there's a lot of pre-written glob code already, and it's handy enough, so including that seems nice. OTOH, RegEx is practically against my religion (and I like Rebol's PARSE). So my leaning is that if a problem is something that simple globbing can't handle, it's best to offer a callout/hook where people with problems that complex can use tools of their choice.
The target here is to be portable C++ code, binaryen tests building on linux using gcc and clang and msvc for windows.
But yeah, simple matching on