Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arc4random compat #10711

Merged
merged 3 commits into from Mar 17, 2020
Merged

Remove arc4random compat #10711

merged 3 commits into from Mar 17, 2020

Conversation

@sbc100
Copy link
Collaborator

sbc100 commented Mar 17, 2020

This was added back in 2013 but the rational seems to be lost to
that sands of time.

See: a5c78a5

I see no reason to maintain compatibility with this BSD-only function.

Fixes: #10709

This was added back in 2013 but the rational seems to be lost to
that sands of time.

See:  a5c78a5

I see no reason to maintain compatibility with this BSD-only function.

Fixes: #10709
@sbc100 sbc100 requested a review from kripken Mar 17, 2020
@Beuc

This comment has been minimized.

Copy link
Contributor

Beuc commented Mar 17, 2020

Technically, for GNU/Linux it's present in libbsd which itself has dozens of reverse-dependencies.
As far as RenPyWeb is concerned, it seems to be picked by libzip and ffmpeg, though they appear to work fine without arc4random.
I would recommend checking with popular libraries and adding a ChangeLog.md entry.

Copy link
Member

kripken left a comment

Probably this was to get some codebase working, but yeah, sgtm to remove it, and point people to libbsd.

@sbc100 sbc100 merged commit 918446e into master Mar 17, 2020
33 checks passed
33 checks passed
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-fastcomp Your tests passed on CircleCI!
Details
ci/circleci: build-upstream-linux Your tests passed on CircleCI!
Details
ci/circleci: build-upstream-mac Your tests passed on CircleCI!
Details
ci/circleci: build-upstream-windows Your tests passed on CircleCI!
Details
ci/circleci: flake8 Your tests passed on CircleCI!
Details
ci/circleci: test-ab Your tests passed on CircleCI!
Details
ci/circleci: test-browser-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-browser-firefox Your tests passed on CircleCI!
Details
ci/circleci: test-c Your tests passed on CircleCI!
Details
ci/circleci: test-d Your tests passed on CircleCI!
Details
ci/circleci: test-e Your tests passed on CircleCI!
Details
ci/circleci: test-f Your tests passed on CircleCI!
Details
ci/circleci: test-ghi Your tests passed on CircleCI!
Details
ci/circleci: test-jklmno Your tests passed on CircleCI!
Details
ci/circleci: test-other Your tests passed on CircleCI!
Details
ci/circleci: test-p Your tests passed on CircleCI!
Details
ci/circleci: test-qrst Your tests passed on CircleCI!
Details
ci/circleci: test-sanity Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-browser-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-browser-firefox Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-minimal-windows Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-other Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-other-mac Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-sockets-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasm0 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasm2 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasm2js1 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasm3 Your tests passed on CircleCI!
Details
ci/circleci: test-uvwxyz Your tests passed on CircleCI!
Details
ci/circleci: test-wasm0 Your tests passed on CircleCI!
Details
ci/circleci: test-wasm2 Your tests passed on CircleCI!
Details
ci/circleci: test-wasm3 Your tests passed on CircleCI!
Details
@sbc100 sbc100 deleted the remove_arc4random branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.