Update WebGPU #11737
Update WebGPU #11737
Conversation
kainino0x
force-pushed
the
webgpu-update
branch
2 times, most recently
from
ba0b3e8
to
08f88c9
Compare
- remove deprecated webgpu.h struct members no longer needed for padding - update webgpu_compiletest
|
@austinEng PTAL! I recommend viewing each commit separately. |
tools/system_libs.py
Outdated
| @@ -1687,6 +1695,9 @@ def add_library(lib): | |||
| else: | |||
| add_library(system_libs_map['libsockets']) | |||
|
|
|||
| if shared.Settings.USE_WEBGPU: | |||
| add_library(system_libs_map['libwebgpu_cpp']) | |||
There was a problem hiding this comment.
I think this should go on line 1681 (which is indented in)
There was a problem hiding this comment.
That's in the middle of sanitization stuff so I left it here but indented it properly.
Actually, no additional comments now |
|
@kripken I think this is ready to go. Would you like to re-review? (Please go ahead and land whenever ready.) |
|
Hm, test_minimal_runtime_code_size failed, but I don't know what changed that. |
|
I tried reproducing the test_minimal_runtime_code_size failure locally, but |
|
hm, now I'm getting |
|
Hm, I guess merging with top-of-tree fixed the CI, or it got fixed separately. |
|
Landing with two approvals, thanks all! |
Should be as close as possible to the top of tree webgpu.h while being compatible with the top of tree Dawn header.
This re-adds webgpu_cpp.{h,cpp} so they can be guaranteed to be compatible with Emscripten's webgpu.h.
The new mapping code has been specifically tested locally, and the rest was tested against a large graphics application that uses many (but certainly not all) of these features.
Reviewing each commit separately is recommended.