Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable linker string merging. NFC #14142

Merged
merged 1 commit into from May 11, 2021
Merged

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 11, 2021

The llvm roller is currently blocked due to
https://bugs.llvm.org/show_bug.cgi?id=50291.

This change disables linker string merging, thus allowing the llvm
roller to continue. In the future re-enable and let emscripten
CI verify any llvm-side fix.

The llvm roller is currently blocked due to
https://bugs.llvm.org/show_bug.cgi?id=50291.

This change disables linker string merging, thus allowing the llvm
roller to continue.  In the future re-enable and let emscripten
CI verify any llvm-side fix.
@sbc100 sbc100 changed the title Temporarily disable linking string merging. NFC Temporarily disable linker string merging. NFC May 11, 2021
@sbc100 sbc100 requested a review from dschuff May 11, 2021 00:06
@sbc100
Copy link
Collaborator Author

sbc100 commented May 11, 2021

The test_sqlite crash crept in because I was testing locally with EMTEST_SKIP_SLOW.

@dschuff dschuff enabled auto-merge (squash) May 11, 2021 00:46
@sbc100 sbc100 disabled auto-merge May 11, 2021 00:48
@sbc100 sbc100 merged commit aae5159 into main May 11, 2021
@sbc100 sbc100 deleted the lld_disable_string_merging branch May 11, 2021 00:48
sbc100 added a commit that referenced this pull request May 11, 2021
Followup to #14142, but apply to all calls to wasm-ld.
sbc100 added a commit that referenced this pull request May 11, 2021
Followup to #14142, but apply to all calls to wasm-ld.

Fixes: #14147
sbc100 added a commit that referenced this pull request May 11, 2021
Followup to #14142, but apply to all calls to wasm-ld.

Fixes: #14147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants