Fix printing of 4 byte UTF-8 characters #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| buffer.push(code); | ||
| if (code > 191 && code < 224) { | ||
| if (((code & 0xE0) ^ 0xC0) == 0) { // 110xxxxx |
There was a problem hiding this comment.
As a (micro(?)-)optimization, could this be written as if ((code & 0xE0) == 0xC0), and the same for the check below on line 404? That would save an xor.
|
Please rebase on incoming, so the diff here contains just your new code. |
|
Yeah, sorry about that, sometimes I love git and sometimes it cheerfully permits me to screw myself over...let me see if I can unpick this mess... |
|
Right, fixed. @juj wasn't too concerned about performance but I do think it's semantically clearer so I like. |
|
I don't really understand this or utf ;) but looks good and if the previous test passes + a new testcase now works, then excellent. thanks! |
kripken
added a commit
that referenced
this pull request
Aug 20, 2013
Fix printing of 4 byte UTF-8 characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Carrying on from the original issue reported at #1382 where I screwed up the conversion to a PR, here is a clean set of commits ready to be pulled.
The only test I ran was
python tests/runner.py test_utf.