Repository navigation
SDL2_mixer: add support for MID - #16556
Merged
Merged
Conversation
sbc100
approved these changes
Mar 22, 2022
Collaborator
|
I'd be ok with landing this without tests for now. |
kripken
approved these changes
Mar 23, 2022
Contributor
Author
|
Is there a good place for me to add more details about this in the docs somewhere? esp. the instructions for providing your own sound files |
Member
|
Hmm, good idea! I don't see a page for SDL2, actually. If you have time, adding a new page might be good. But also just mentioning it in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstreaming changes from a local fork to enable SDL2_mixer to use timidity to provide MIDI support.
To use, you must provide your own sound files. I sourced mine from here.
And mount them here:
(that's the default place timidity will look for configuration)
I didn't add any tests because I wasn't sure if you'd want something like all of freepats in the repo for one test. Although if that is OK, it might be nice to also just provide these sound files by default (and with an option to suppress/enable that)