Support different node flags for different versions of node. #18070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
support_modern_node
branch
30 times, most recently
from
912be29
to
1ab17d7
Compare
sbc100
force-pushed
the
support_modern_node
branch
5 times, most recently
from
ed1e41f
to
f7397fc
Compare
sbc100
force-pushed
the
support_modern_node
branch
3 times, most recently
from
9de4d22
to
20d8535
Compare
sbc100
force-pushed
the
support_modern_node
branch
2 times, most recently
from
5147440
to
73c4535
Compare
kripken
approved these changes
Oct 19, 2022
.circleci/config.yml
Outdated
| @@ -6,7 +6,10 @@ orbs: | |||
| executors: | |||
| linux-node: | |||
| docker: | |||
| - image: circleci/node:stretch | |||
| - image: cimg/node:19.0.0 | |||
There was a problem hiding this comment.
Do we need both the docker image for node 19 and also to download it manually below?
There was a problem hiding this comment.
This is actually a separate change, I think i'll just revert it. we don't run these new tests in the linux-node image.
sbc100
force-pushed
the
support_modern_node
branch
from
73c4535
to
9feca29
Compare
aheejin
approved these changes
Oct 19, 2022
kripken
approved these changes
Oct 19, 2022
This is mostly about what flags to pass to node during testing, but also applies to `CMAKE_CROSSCOMPILING_EMULATOR` and to the #! used in autoconf tests.
sbc100
force-pushed
the
support_modern_node
branch
from
9feca29
to
cf50cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly about what flags to pass to node during testing, but also applies to
CMAKE_CROSSCOMPILING_EMULATORand to the #! used in autoconf tests.