Reuse device handle in emscripten_webgpu_get_device #18082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this function creates a new wrapper each time it's called. As a result, what is a single device in JavaScript looks like different devices in C (the handles are different), and there is a new entry in WebGPU.mgrDevice for each call. With this change, the same handle is returned each time. Note that each new device wrapper currently also leaks a queue wrapper (see the comment at <https://github.com/emscripten-core/emscripten/blob/0c4fba0371abc8c7219dc481a02ea4a464b14641/src/library_webgpu.js#L190>), so this change also reduces the impact of that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this function creates a new wrapper each time it's called. As a result, what is a single device in JavaScript looks like different devices in C (the handles are different), and there is a new entry in WebGPU.mgrDevice for each call.
With this change, the same handle is returned each time.
Note that each new device wrapper currently also leaks a queue wrapper (see the comment at
emscripten/src/library_webgpu.js
Line 190 in 0c4fba0