[tsgen] Make commonjs module output compatible with tsc. #22988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables commonjs modules to be imported into TypeScript using the same syntax as ESM modules e.g. `import moduleFactory from './embind_tsgen.js';`
brendandahl
force-pushed
the
tsgen-commonjs
branch
from
033cd49 to
88463f9
Compare
sbc100
reviewed
Nov 21, 2024
sbc100
reviewed
Nov 21, 2024
brendandahl
commented
Nov 21, 2024
| @parameterized({ | ||
| '': [[]], | ||
| 'with_jsgen': [['-sEMBIND_AOT']] | ||
| 'commonjs': [['-sMODULARIZE'], ['--module', 'commonjs', '--moduleResolution', 'node']], |
There was a problem hiding this comment.
FYI: this roughly matches how emscripten output is used in g3.
sbc100
approved these changes
Nov 21, 2024
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
…core#22988) This enables commonjs modules to be imported into TypeScript using the same syntax as ESM modules e.g. `import moduleFactory from './embind_tsgen.js';`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables commonjs modules to be imported into TypeScript using the same syntax as ESM modules e.g.
import moduleFactory from './embind_tsgen.js';