From 7a2592c399a86e5208a4ea530af0c1eca029bc1e Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Thu, 2 Oct 2025 14:42:52 -0700 Subject: [PATCH] Remove double-logging of sub-commands. NFC The `check_call` function already does `print_compiler_stage`. --- tools/building.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/building.py b/tools/building.py index 4f02511804ed4..58c3756923241 100644 --- a/tools/building.py +++ b/tools/building.py @@ -378,8 +378,8 @@ def acorn_optimizer(filename, passes, extra_info=None, return_output=False, work if settings.VERBOSE: cmd += ['--verbose'] if return_output: - shared.print_compiler_stage(cmd) if shared.SKIP_SUBPROCS: + shared.print_compiler_stage(cmd) return '' return check_call(cmd, stdout=PIPE).stdout @@ -390,8 +390,8 @@ def acorn_optimizer(filename, passes, extra_info=None, return_output=False, work output_file = basename + '.jso%d.js' % acorn_optimizer.counter shared.get_temp_files().note(output_file) cmd += ['-o', output_file] - shared.print_compiler_stage(cmd) if shared.SKIP_SUBPROCS: + shared.print_compiler_stage(cmd) return output_file check_call(cmd) save_intermediate(output_file, '%s.js' % passes[0]) @@ -1245,8 +1245,8 @@ def run_binaryen_command(tool, infile, outfile=None, args=None, debug=False, std if settings.GENERATE_SOURCE_MAP and outfile and tool in ['wasm-opt', 'wasm-emscripten-finalize', 'wasm-metadce']: cmd += [f'--input-source-map={infile}.map'] cmd += [f'--output-source-map={outfile}.map'] - shared.print_compiler_stage(cmd) if shared.SKIP_SUBPROCS: + shared.print_compiler_stage(cmd) return '' ret = check_call(cmd, stdout=stdout).stdout if outfile: