From 96f6a9e26bc68959de5ca1eb22f856f2c0e58e0f Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Mon, 17 Nov 2025 14:51:24 -0800 Subject: [PATCH] Fix test arguments in test_dylink_dso_needed I fixed the arguments so the non-worker version of this test now runs, but sadly is currently failing so I opened #25814 --- test/test_browser.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/test_browser.py b/test/test_browser.py index b5bcf9296141c..82ef833dabf98 100644 --- a/test/test_browser.py +++ b/test/test_browser.py @@ -3636,11 +3636,12 @@ def test_dlopen_blocking(self): # verify that dynamic linking works in all kinds of in-browser environments. # don't mix different kinds in a single test. @parameterized({ - '': ([0],), - 'inworker': ([1],), + '': (0,), + 'inworker': (1,), }) def test_dylink_dso_needed(self, inworker): - self.cflags += ['-O2'] + if not inworker: + self.skipTest('https://github.com/emscripten-core/emscripten/issues/25814') def do_run(src, expected_output, cflags): # XXX there is no infrastructure (yet ?) to retrieve stdout from browser in tests. @@ -3670,7 +3671,7 @@ def do_run(src, expected_output, cflags): return rtn; } ''' % expected_output) - # --proxy-to-worker only on main + # --proxy-to-worker only when linking the main module if inworker: cflags += ['--proxy-to-worker', '-Wno-deprecated'] self.btest_exit('test_dylink_dso_needed.c', cflags=['--post-js', 'post.js'] + cflags)