[CI] Do some testing with bun engine. NFC #25903
Merged
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Dec 4, 2025
| echo "BUN_ENGINE = os.path.expanduser('~/.bun/bin/bun')" >> ~/emsdk/.emscripten | ||
| echo "JS_ENGINES = [BUN_ENGINE]" >> ~/emsdk/.emscripten | ||
| - run-tests: | ||
| test_targets: "core0.test_hello_world" |
Member
There was a problem hiding this comment.
Perhaps it would be faster to append the install bun and run tests steps to another runner, saving the checkout/pip/install-emsdk steps?
Collaborator
Author
There was a problem hiding this comment.
I think since its only 30 seconds or so, and we are likely going to add more tests here its clearer to keep it in its own runner for now.
We could combine some of the quicker runners at some point, but attaching a shared workspace also seems to take about 30 seconds so I'm not sure its any quicker than just installing emsdk directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.