chrome_webgl2_workaround #4945
Merged
chrome_webgl2_workaround #4945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juj
commented
Feb 14, 2017
| usage = 0x88E8; // GL_DYNAMIC_DRAW | ||
| break; | ||
| } | ||
| #endif |
Collaborator
Author
There was a problem hiding this comment.
This block was actually missing #if LEGACY_GL_EMULATION, coming from an old commit d2a3ea8.
…thout the new WebGL 2 function entry points. Fix a bug in glBufferData() where legacy GL emulation was used without gating for #if LEGACY_GL_EMULATION.
juj
force-pushed
the
chrome_webgl2_workaround
branch
from
8f26dc5 to
cab6be0
Compare
erunehtar
approved these changes
Feb 14, 2017
erunehtar
left a comment
erunehtar
left a comment
There was a problem hiding this comment.
Verified, the error goes away in Chrome 56.
Member
|
Overall lgtm, but do we not expect chrome to fix this soon? (if soon, then maybe best to just wait?) |
|
@kripken without this fix we can't upgrade Emscripten otherwise it breaks running in Chrome release today. |
Member
|
I see, ok. |
Collaborator
Author
They said they will have the fix in Chrome 58, and they're asking to land this workaround in the meanwhile and not wait. So I'll go ahead and push this in. Thanks @gouletr for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around the issue that Chrome 56 and Chrome 57 shipped WebGL 2 without the new WebGL 2 function entry points. Fix a bug in glBufferData() where legacy GL emulation was used without gating for #if LEGACY_GL_EMULATION.