Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICU port #7167

Merged
merged 2 commits into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@zekoz
Copy link
Contributor

commented Sep 21, 2018

No description provided.

@zekoz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2018

Could you make a github fork of https://github.com/unicode-org/icu in emscripten-ports?

@kripken
Copy link
Member

left a comment

Thanks! Mostly just minor comments on the code.

We also need a test for this, see test_embuilder in tests/test_sanity.py.

Please also add yourself to AUTHORS.

Show resolved Hide resolved embuilder.py Outdated
Show resolved Hide resolved tools/ports/icu.py Outdated
@kripken

This comment has been minimized.

Copy link
Member

commented Sep 28, 2018

Do we need any local changes to ICU? if not, I don't think we need a fork of their repo, can just point directly to it as the PR does now.

@zekoz zekoz force-pushed the zekoz:icu branch from 2bb9123 to d5c2d05 Sep 29, 2018

@zekoz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 29, 2018

No local changes, compiles as is. Added test case. Added to AUTHORS.

@zekoz zekoz force-pushed the zekoz:icu branch from d5c2d05 to 7bb4be9 Sep 29, 2018

@kripken

This comment has been minimized.

Copy link
Member

commented Oct 2, 2018

Great, thanks @zekoz!

@kripken kripken merged commit 7ea0163 into emscripten-core:incoming Oct 2, 2018

0 of 4 checks passed

ci/circleci: build CircleCI is running your tests
Details
ci/circleci: build-docs CircleCI is running your tests
Details
ci/circleci: flake8 CircleCI is running your tests
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.