Clarify addRunDependency assert #7516
Merged
Conversation
so the user doesn't get a cryptic "Assertion failed: undefined"
kripken
merged commit 9646b6b
into
emscripten-core:incoming
26 checks passed
26 checks passed
In general you can just load the JS generated from the file packager, in another script tag. So if addRunDependency isn't an option, perhaps the app can wait on a signal you manage yourself. I'm not sure though why addRunDependency wouldn't work with pthreads - maybe that's fixable? |
haberbyte
added a commit
to haberbyte/emscripten
that referenced
this pull request
Jan 31, 2021
so the user doesn't get a cryptic "Assertion failed: undefined"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
so the user doesn't get a cryptic "Assertion failed: undefined"
Bonus question: I'm using addRunDependency in Module.preInit to download the base .data files (generated independently). Is that supported somehow else?