Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify how to use file packages #7524

Merged
merged 1 commit into from Nov 19, 2018
Merged

Conversation

@Beuc
Copy link
Contributor

@Beuc Beuc commented Nov 17, 2018

The current documentation had tricked me in a convoluted solution :)

Copy link
Member

@kripken kripken left a comment

Thanks, just one minor change request.

@@ -57,11 +57,12 @@ Packaging using the file packager tool
You can also run the *file packager* manually using the instructions at the top of `file_packager.py <https://github.com/kripken/emscripten/blob/master/tools/file_packager.py>`_.

The file packager generates a **.data** file and **.js** file. The **.js** file contains the code to use the data file, and must be loaded *before* loading your main compiled code.
For instance, add ``<script>`` tags at the end of your ``--shell-file`` right before ``{{{ SCRIPT }}}```.

This comment has been minimized.

@kripken

kripken Nov 19, 2018
Member

please put this in parentheses ( )

This comment has been minimized.

@Beuc

Beuc Nov 19, 2018
Author Contributor

Done!

@Beuc Beuc force-pushed the Beuc:patch-2 branch from 153258d to 5cee48e Nov 19, 2018
@kripken kripken merged commit 919d14b into emscripten-core:incoming Nov 19, 2018
23 of 26 checks passed
23 of 26 checks passed
ci/circleci: test-browser-chrome CircleCI is running your tests
Details
ci/circleci: test-browser-firefox CircleCI is running your tests
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-upstream Your tests passed on CircleCI!
Details
ci/circleci: flake8 Your tests passed on CircleCI!
Details
ci/circleci: test-ab Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen0 Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen1 Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen2 Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen3 Your tests passed on CircleCI!
Details
ci/circleci: test-c Your tests passed on CircleCI!
Details
ci/circleci: test-d Your tests passed on CircleCI!
Details
ci/circleci: test-e Your tests passed on CircleCI!
Details
ci/circleci: test-f Your tests passed on CircleCI!
Details
ci/circleci: test-ghi Your tests passed on CircleCI!
Details
ci/circleci: test-jklmno Your tests passed on CircleCI!
Details
ci/circleci: test-other Your tests passed on CircleCI!
Details
ci/circleci: test-p Your tests passed on CircleCI!
Details
ci/circleci: test-qrst Your tests passed on CircleCI!
Details
ci/circleci: test-sanity Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-binaryen2 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-other Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasmobj2 Your tests passed on CircleCI!
Details
ci/circleci: test-uvwxyz Your tests passed on CircleCI!
Details
@Beuc Beuc deleted the Beuc:patch-2 branch Nov 19, 2018
haberbyte added a commit to haberbyte/emscripten that referenced this pull request Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants