New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow again using EMCC_LOCAL_PORTS along with official ports #8054

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@Beuc
Copy link
Contributor

Beuc commented Feb 10, 2019

EMCC_LOCAL_PORTS now overrides all ports, so it's not possible anymore to e.g. point to a patched SDL2 while using ZLIB.

(also, nice to see a clean-up in that area, but when changing a public interface with emcc, a note in ChangeLog.md please? :))

@kripken

This comment has been minimized.

Copy link
Member

kripken commented Feb 11, 2019

Thanks!

Yeah, sorry, stuff like this should be noted in the Changelog, I'll add this.

@kripken kripken merged commit bd2ab81 into emscripten-core:incoming Feb 11, 2019

28 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-upstream Your tests passed on CircleCI!
Details
ci/circleci: flake8 Your tests passed on CircleCI!
Details
ci/circleci: test-ab Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen0 Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen1 Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen2 Your tests passed on CircleCI!
Details
ci/circleci: test-binaryen3 Your tests passed on CircleCI!
Details
ci/circleci: test-browser-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-browser-firefox Your tests passed on CircleCI!
Details
ci/circleci: test-c Your tests passed on CircleCI!
Details
ci/circleci: test-d Your tests passed on CircleCI!
Details
ci/circleci: test-e Your tests passed on CircleCI!
Details
ci/circleci: test-f Your tests passed on CircleCI!
Details
ci/circleci: test-ghi Your tests passed on CircleCI!
Details
ci/circleci: test-jklmno Your tests passed on CircleCI!
Details
ci/circleci: test-other Your tests passed on CircleCI!
Details
ci/circleci: test-p Your tests passed on CircleCI!
Details
ci/circleci: test-qrst Your tests passed on CircleCI!
Details
ci/circleci: test-sanity Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-binaryen0 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-binaryen2 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-browser-chrome Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-other Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasmobj0 Your tests passed on CircleCI!
Details
ci/circleci: test-upstream-wasmobj2 Your tests passed on CircleCI!
Details
ci/circleci: test-uvwxyz Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment