Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 8042 - _emscripten_traverse_stack updated #8159

Open
wants to merge 7 commits into
base: incoming
from
Open
Changes from 6 commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -4446,34 +4446,9 @@ LibraryManager.library = {
);
},

// Returns [parentFuncArguments, functionName, paramListName]
// Function disabled
_emscripten_traverse_stack: function(args) {
if (!args || !args.callee || !args.callee.name) {
return [null, '', ''];
}

var funstr = args.callee.toString();
var funcname = args.callee.name;
var str = '(';
var first = true;
for (var i in args) {
var a = args[i];
if (!first) {
str += ", ";
}
first = false;
if (typeof a === 'number' || typeof a === 'string') {
str += a;
} else {
str += '(' + typeof a + ')';
}
}
str += ')';
var caller = args.callee.caller;
args = caller ? caller.arguments : [];
if (first)
str = '';
return [args, funcname, str];
return null;
This conversation was marked as resolved by woosle1234

This comment has been minimized.

Copy link
@kripken

kripken Feb 22, 2019

Member

Thanks for the PR!

Looking earlier up, it looks like the function returns [null, '', ''] if it can't do better, so maybe that's what we should be returning here? In any case, though, I think we should remove this function, and make the function calling it not try to call it.

This comment has been minimized.

Copy link
@woosle1234

woosle1234 Feb 28, 2019

Author

I attempted to remove the function any instance of it being called

},

emscripten_get_callstack_js__deps: ['_emscripten_traverse_stack'],
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.