-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use __builtin_rint(f) to implement rint(f) #9239
Conversation
Do we have a way to mark or record such changes so that they don't get lost when we next upgrade musl? |
We've marked changes in musl with @quantum5 have you verified that those get lowered into the proper intrinsics (even with |
Yes, after the latest commit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too bad we don't have codegen tests in Emscripten :/
Are we guaranteed to have |
Fixes #9236.